Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest lisk-client - Closes #2004 #2013

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented May 15, 2019

What issue have I solved?

#2004

How have I implemented/fixed it?

  • changed it in package.json
  • updated all imports

How has this been tested?

  • check that all tests and build pass

Review checklist

@slaweet slaweet self-assigned this May 15, 2019

🐛 Ensure transaction amount is string
because lisk-client throws a error if amount is number

@slaweet slaweet requested a review from osvaldovega May 16, 2019

@osvaldovega
Copy link
Contributor

left a comment

💪🏻great thx Vit for the update

@osvaldovega osvaldovega added the ready label May 16, 2019

@slaweet slaweet merged commit 4911053 into development May 16, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the 2004-use-liskhq-lisk-client branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.