Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Trezor Model T - Closes #1848 #2014

Open
wants to merge 15 commits into
base: development
from

Conversation

Projects
None yet
4 participants
@michaeltomasik
Copy link
Member

commented May 15, 2019

What issue have I solved?

#1848

How have I implemented/fixed it?

Removed legacy code

How has this been tested?

  1. Go to splashScreen
  2. Try to login with different versions of hardwareWallets
  3. Send Transaction with different hardwareWallets.
  4. Vote with different hardwareWallets

Review checklist

@michaeltomasik michaeltomasik added this to the Version 1.18.0 milestone May 15, 2019

@michaeltomasik michaeltomasik requested review from massao and osvaldovega May 15, 2019

@michaeltomasik michaeltomasik self-assigned this May 15, 2019

@massao
Copy link
Contributor

left a comment

👍

@slaweet slaweet removed this from the Version 1.18.0 milestone May 15, 2019

@massao massao requested a review from Efefefef May 15, 2019

@Efefefef
Copy link
Contributor

left a comment

  • 🐛 'Lisk Hub currently supports Ledger Nano S and Trezor wallets' - Tresor model T is only supported

  • 🐛 The whole account div has clickable pointer. 'Select this account' is only in fact clickable.

image

  • 🐛 Login with HW wallet acc. Sign out. Attempt to login with HW wallet acc again - You got infinite loading

image

  • 🐛 You got logged out when you disconnect HW wallet, even if you were logged in as not-HW wallet account

  • 🐛 No transfer TX's message is shown on the Tresor T

  • 🐛 Create the transaction, instead of confirming on the wallet click Edit transaction in Hub, change the amount and create a new one. Now get the wallet and confirm the transaction. The first one was confirmed instead of the second one, because you send no cancellation to the wallet for the first one. Same for Tresor and Ledger. Similar problem with voting.

  • 🐛 When voting with Tresor you have 'Confirm vote on Ledger Nano S' on the screen

  • 🐛 It is possible to make Hub show dupicate HW wallet. Tell me if you need the exact steps to reproduce. It's a bit tricky from black box perspective

image

@reyraa

  1. We have the network switcher available on the Wallet Accounts page. When changing the network we should either reload accounts from HW wallet or remove the network switcher at all.
  2. If you have 1 hw wallet connected Go Back link on the Wallet Accounts page just reloads the stored accounts. Should it lead to splashscreen instead?

@yasharAyari I have not tested the feature with >1 wallet of the same type, because we have only one of a kind

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

🐛 Login with Ledger S - You got infinite loading if this the only connected HW wallet

🐛 You got logged out when you disconnect Ledger S or Tresor T wallet, even if you were logged in as not-HW wallet account

🐛 Back button should be disabled when voting with HW wallet
image

🐛 When editing labels for accounts of HWwallet2 app removes the saved labels for HWwallet1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.