Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify LSK getTransactions API util filters - Closes #1988 #2015

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented May 15, 2019

What issue have I solved?

#1988

How have I implemented/fixed it?

I separated the filter processing into several functions

How has this been tested?

Check that all tests still pass.

Review checklist

@slaweet slaweet self-assigned this May 15, 2019

@yasharAyari
Copy link
Member

left a comment

thank you @slaweet.

@slaweet slaweet merged commit 5249842 into development May 15, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.854%
Details

@slaweet slaweet deleted the 1988-simplify-LSK-get-transactions-filters branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.