Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify transaction actions - Closes #2018 #2019

Merged
merged 30 commits into from May 21, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented May 15, 2019

What issue have I solved?

#2018

How have I implemented/fixed it?

I went through all actions exported from https://github.com/LiskHQ/lisk-hub/blob/development/src/actions/transactions.js and with each did one of the following:

  • Wrote comment above it that explains why we need that action
  • Removed the action as duplicate and updated code that used it to use another action
  • I didn't touch the sent action as it's currently worked on in #2005

How has this been tested?

Check that all tests still pass.

Review checklist

@slaweet slaweet self-assigned this May 15, 2019

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from dbb52ae to 8b78a9d May 15, 2019

slaweet added some commits May 15, 2019

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from 9025260 to 32c6e8a May 15, 2019

slaweet added some commits May 15, 2019

♻️ Replace transactionsFiltered filtered action
... with transactionsLoaded

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from a733450 to f4804eb May 16, 2019

slaweet added some commits May 16, 2019

@slaweet slaweet marked this pull request as ready for review May 16, 2019

@slaweet slaweet requested review from massao and yasharAyari May 16, 2019

Show resolved Hide resolved src/actions/transactions.js Outdated
Show resolved Hide resolved src/actions/transactions.js Outdated

slaweet added some commits May 17, 2019

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from 4f0608c to ac1f0e0 May 17, 2019

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from ac1f0e0 to 2d0405e May 20, 2019

slaweet added some commits May 17, 2019

@slaweet slaweet force-pushed the 2018-simplify-transaction-actions branch from 2d0405e to e977898 May 20, 2019

slaweet added some commits May 20, 2019

@slaweet slaweet requested a review from yasharAyari May 20, 2019

slaweet added some commits May 20, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

I fixed the naming as discussed. Please check again @yasharAyari

@slaweet slaweet merged commit 1fc3fba into development May 21, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the 2018-simplify-transaction-actions branch May 21, 2019

@slaweet slaweet added the ready label May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.