Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Summary Step(2/3) of send BTC #2035

Merged
merged 7 commits into from May 17, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

commented May 16, 2019

What issue have I solved?

#1891

How have I implemented/fixed it?

Updated how data is displayed on the Summary page, and updated the data passed to the submitTransfer function to be as it's expected by: #2005

How has this been tested?

  • Enable btc on localStorage (localStorage.setItem('btc', true));
  • Update the active token to 'LSK':
    • $r.store.dispatch({type:'SETTINGS_UPDATE_TOKEN', data: { token: { active: 'LSK', list: {BTC: true, LSK: true} }}}) Note that React dev tools have to be active for $r to be defined.
    • Or dispatching {type:'SETTINGS_UPDATE_TOKEN', data: { token: { active: 'LSK', list: {BTC: true, LSK: true} }}} through Redux DevTools.
  • Go to /wallet/send, input the values and go to next step;
  • Check that the data are being displayed as it should for LSK;
  • Go to /wallet;
  • Update the active token to 'BTC':
    • $r.store.dispatch({type:'SETTINGS_UPDATE_TOKEN', data: { token: { active: 'BTC', list: {BTC: true, LSK: true} }}}) Note that React dev tools have to be active for $r to be defined.
    • Or dispatching {type:'SETTINGS_UPDATE_TOKEN', data: { token: { active: 'BTC', list: {BTC: true, LSK: true} }}} through Redux DevTools.
  • Go to /wallet/send, input the values and go to next step;
  • Check that the data are being displayed as it should for BTC;

Review checklist

@massao massao self-assigned this May 16, 2019

massao and others added some commits May 16, 2019

♻️ Adjust tooltip and recipient on summary
Updat recipient field to only show the second text if address is
bookmarked.
Updat tooltip text to be BTC related when BTC is the active toke
Update generated Strings.

@massao massao requested review from osvaldovega and slaweet May 17, 2019

@slaweet
Copy link
Member

left a comment

Thank you, @massao

@massao massao merged commit 67abbaa into development May 17, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.002%) to 94.721%
Details

@massao massao deleted the 1891-implement-summary-step2-3-send-btc branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.