Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "start voting" - Closes #1971 #2036

Merged
merged 37 commits into from May 22, 2019

Conversation

2 participants
@slaweet
Copy link
Member

commented May 20, 2019

What issue have I solved?

#1971

How have I implemented/fixed it?

  • Implemented the design.
  • Cleaned up some unnecessary code
  • Created two new Toolbox components (CheckBox and Tabs)

How has this been tested?

Review checklist

slaweet added some commits May 17, 2019

@slaweet slaweet self-assigned this May 20, 2019

@slaweet slaweet force-pushed the 1971-implement-start-voting branch from 6a2db6c to 33d785e May 20, 2019

@slaweet slaweet force-pushed the 1971-implement-start-voting branch from 33d785e to 776cf72 May 20, 2019

slaweet added some commits May 20, 2019

@slaweet slaweet marked this pull request as ready for review May 20, 2019

slaweet added some commits May 21, 2019

slaweet added some commits May 21, 2019

@slaweet slaweet requested a review from massao May 21, 2019

@massao
Copy link
Contributor

left a comment

🐛 When sign in with an account that have already voted, the votes column show up even without clicking start voting:
image

🐛 When there is no votes yet, and you click on the start voting, select a vote and hit cancel, the vote column is kept on the table:
image

Show resolved Hide resolved src/components/toolbox/tabs/index.js Outdated

.checkbox {
display: inline-block;
width: 16px;
height: 16px;
position: relative;
z-index: 2;

This comment has been minimized.

Copy link
@massao

massao May 21, 2019

Contributor

Maybe would be good to create some variables for the z-index, so it's easier, something similar to:

--background-index: 0;
--base-index: 3;
--foreground-index: 6;
--overlay-index: 10;

So it would be easier to visualize which element is in front and which are in the back.

This comment has been minimized.

Copy link
@slaweet

slaweet May 21, 2019

Author Member

Somehow tried to do this :-)

slaweet added some commits May 21, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

🐛 When sign in with an account that have already voted, the votes column show up even without clicking start voting

This is actually agreed by @reyraa, because otherwise you cannot see your votes without "Start voting". I forgot to mention it in the PR description. But in the screenshot is another bug that I fixed.

🐛 When there is no votes yet, and you click on the start voting, select a vote and hit cancel, the vote column is kept on the table:

Fixed.

@slaweet slaweet requested a review from massao May 21, 2019

@massao

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

🐛 Now the votes column doesn't show up when having voted already.
image

slaweet added some commits May 22, 2019

🐛 Fix vote column show condition
The problem was that votes column doesn't show up when having voted already
@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

Good catch @massao, thanks.
Fixed. Please check again.

@massao

massao approved these changes May 22, 2019

Copy link
Contributor

left a comment

👍

@slaweet slaweet merged commit 120aaa9 into development May 22, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the 1971-implement-start-voting branch May 22, 2019

@slaweet slaweet added the ready label May 22, 2019

@reyraa reyraa added this to Pull Requests in Version 1.18.0 via automation May 27, 2019

@reyraa reyraa moved this from Pull Requests to Merged Pull Requests in Version 1.18.0 May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.