New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement voting summary page - Closes #1972 #2048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
1972-implement-voting-summary-page
branch
2 times, most recently
from
May 22, 2019 09:33
7d5ed6b
to
93c3171
Compare
to get votes from url, e.g. http://localhost:8080/#/delegatesV2/vote?votes=joel,hirish,cc001,mrv,12e0asdlhiu&unvotes=bioly,aaa,bbb
slaweet
force-pushed
the
1972-implement-voting-summary-page
branch
from
May 22, 2019 09:36
93c3171
to
f6cb0c7
Compare
massao
suggested changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
massao
approved these changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1972
How have I implemented/fixed it?
I implemented:
votingV2
component/folder todelegatesV2
so that I could usevotingV2
for the new page where the name makes more sense.This is still left to do, but since this PR is already huge, I prefer to include it in PR for #1973:
How has this been tested?
Or go directly to https://ci.lisk.io/test/lisk-hub/PR-2048/#/delegatesV2/vote?votes=joel,hirish,cc001,mrv,12e0asdlhiu,genesis_1,genesis_2,genesis_3,genesis_4,genesis_5,genesis_6,genesis_7,genesis_8,genesis_9,genesis_11,genesis_12,genesis_13,genesis_14,genesis_15,genesis_16,genesis_17,genesis_18,genesis_19&unvotes=bioly,aaa,mrv
Review checklist