Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement voting summary page - Closes #1972 #2048

Merged
merged 28 commits into from May 23, 2019

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 21, 2019

What issue have I solved?

#1972

How have I implemented/fixed it?

I implemented:

  • The vote summary page
  • Generic TransactionSummary component
  • Vote URL processing (see test link below)
  • Guest mode of the delegates section (https://zpl.io/Vkp7l6W)
  • Submitting the transaction (also with 2nd passphrase)
  • Hardware wallet support
  • renames existing votingV2 component/folder to delegatesV2 so that I could use votingV2 for the new page where the name makes more sense.

This is still left to do, but since this PR is already huge, I prefer to include it in PR for #1973:

  • Vote for more than 33 delegates
  • "more than 101 upvotes" error
  • "Not enough LSK" error state

How has this been tested?

Or go directly to https://ci.lisk.io/test/lisk-hub/PR-2048/#/delegatesV2/vote?votes=joel,hirish,cc001,mrv,12e0asdlhiu,genesis_1,genesis_2,genesis_3,genesis_4,genesis_5,genesis_6,genesis_7,genesis_8,genesis_9,genesis_11,genesis_12,genesis_13,genesis_14,genesis_15,genesis_16,genesis_17,genesis_18,genesis_19&unvotes=bioly,aaa,mrv

Review checklist

@slaweet slaweet self-assigned this May 21, 2019
@slaweet slaweet force-pushed the 1972-implement-voting-summary-page branch 2 times, most recently from 7d5ed6b to 93c3171 Compare May 22, 2019 09:33
@slaweet slaweet force-pushed the 1972-implement-voting-summary-page branch from 93c3171 to f6cb0c7 Compare May 22, 2019 09:36
@slaweet slaweet marked this pull request as ready for review May 22, 2019 14:19
@slaweet slaweet requested a review from massao May 23, 2019 06:30
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working fine, just found a small bug, when opening the example link, the header is overlapping some of the content, and it's not possible to scroll it up:
image

@slaweet slaweet requested a review from massao May 23, 2019 15:25
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥇

@massao massao added the ready label May 23, 2019
@slaweet slaweet merged commit b582790 into development May 23, 2019
@reyraa reyraa added this to Pull Requests in Version 1.18.0 via automation May 27, 2019
@reyraa reyraa moved this from Pull Requests to Merged Pull Requests in Version 1.18.0 May 27, 2019
@slaweet slaweet deleted the 1972-implement-voting-summary-page branch May 29, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.18.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants