Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement voting submitted page - Closes #1973 #2065

Merged
merged 25 commits into from May 29, 2019

Conversation

2 participants
@slaweet
Copy link
Member

commented May 23, 2019

What issue have I solved?

#1973

How have I implemented/fixed it?

  • Implemented the success state
  • Implemented the error state
  • "Not enough LSK" error toast
  • "more than 33 upvotes" error toast
  • Vote for more than 33 delegates
  • Vote for more than 33 delegates with a hardware wallet
  • Autologin with hw wallet (see README.md)

How has this been tested?

Try voting with these links:

https://jenkins.lisk.io/test/lisk-hub/PR-2065/#/delegatesV2/vote?votes=genesis_1,genesis_2,genesis_3,genesis_4,genesis_5,genesis_6,genesis_7,genesis_8,genesis_9,genesis_10,genesis_11,genesis_12,genesis_13,genesis_14,genesis_15,genesis_16,genesis_17,genesis_18,genesis_19,genesis_20,genesis_21,genesis_22,genesis_23,genesis_24,genesis_25,genesis_26,genesis_27,genesis_28,genesis_29,genesis_30,genesis_31,genesis_32,genesis_33,genesis_34,genesis_35,genesis_36,genesis_37,genesis_38,genesis_39,genesis_40,genesis_41,genesis_42,genesis_43,genesis_44,genesis_45,genesis_46,genesis_47,genesis_48,genesis_49,genesis_50&unvotes=genesis_51,genesis_52,genesis_53,genesis_54,genesis_55,genesis_56,genesis_57,genesis_58,genesis_59,genesis_60,genesis_61,genesis_62,genesis_63,genesis_64,genesis_65,genesis_66,genesis_67,genesis_68,genesis_69,genesis_70,genesis_71,genesis_72,genesis_73,genesis_74,genesis_75,genesis_76,genesis_77,genesis_78,genesis_79,genesis_80,genesis_81,genesis_82,genesis_83,genesis_84,genesis_85,genesis_86,genesis_87,genesis_88,genesis_89,genesis_90,genesis_91,genesis_92,genesis_93,genesis_94,genesis_95,genesis_96,genesis_97,genesis_98,genesis_99,genesis_100,genesis_101,genesis_102

https://jenkins.lisk.io/test/lisk-hub/PR-2065/#/delegatesV2/vote?unvotes=genesis_1,genesis_2,genesis_3,genesis_4,genesis_5,genesis_6,genesis_7,genesis_8,genesis_9,genesis_10,genesis_11,genesis_12,genesis_13,genesis_14,genesis_15,genesis_16,genesis_17,genesis_18,genesis_19,genesis_20,genesis_21,genesis_22,genesis_23,genesis_24,genesis_25,genesis_26,genesis_27,genesis_28,genesis_29,genesis_30,genesis_31,genesis_32,genesis_33,genesis_34,genesis_35,genesis_36,genesis_37,genesis_38,genesis_39,genesis_40,genesis_41,genesis_42,genesis_43,genesis_44,genesis_45,genesis_46,genesis_47,genesis_48,genesis_49,genesis_50&votes=genesis_51,genesis_52,genesis_53,genesis_54,genesis_55,genesis_56,genesis_57,genesis_58,genesis_59,genesis_60,genesis_61,genesis_62,genesis_63,genesis_64,genesis_65,genesis_66,genesis_67,genesis_68,genesis_69,genesis_70,genesis_71,genesis_72,genesis_73,genesis_74,genesis_75,genesis_76,genesis_77,genesis_78,genesis_79,genesis_80,genesis_81,genesis_82,genesis_83,genesis_84,genesis_85,genesis_86,genesis_87,genesis_88,genesis_89,genesis_90,genesis_91,genesis_92,genesis_93,genesis_94,genesis_95,genesis_96,genesis_97,genesis_98,genesis_99,genesis_100,genesis_101,genesis_102

https://jenkins.lisk.io/test/lisk-hub/PR-2065/#/delegatesV2/vote?votes=genesis_1,genesis_2,genesis_3,genesis_4,genesis_5,genesis_6,genesis_7,genesis_8,genesis_9,genesis_10,genesis_11,genesis_12,genesis_13,genesis_14,genesis_15,genesis_16,genesis_17,genesis_18,genesis_19,genesis_20,genesis_21,genesis_22,genesis_23,genesis_24,genesis_25,genesis_26,genesis_27,genesis_28,genesis_29,genesis_30,genesis_31,genesis_32,genesis_33,genesis_34,genesis_35,genesis_36,genesis_37,genesis_38,genesis_39,genesis_40,genesis_41,genesis_42,genesis_43,genesis_44,genesis_45,genesis_46,genesis_47,genesis_48,genesis_49,genesis_50,genesis_51,genesis_52,genesis_53,genesis_54,genesis_55,genesis_56,genesis_57,genesis_58,genesis_59,genesis_60,genesis_61,genesis_62,genesis_63,genesis_64,genesis_65,genesis_66,genesis_67,genesis_68,genesis_69,genesis_70,genesis_71,genesis_72,genesis_73,genesis_74,genesis_75,genesis_76,genesis_77,genesis_78,genesis_79,genesis_80,genesis_81,genesis_82,genesis_83,genesis_84,genesis_85,genesis_86,genesis_87,genesis_88,genesis_89,genesis_90,genesis_91,genesis_92,genesis_93,genesis_94,genesis_95,genesis_96,genesis_97,genesis_98,genesis_99,genesis_100,genesis_101,joel

To test with our Trezor hardware wallet you can use autologin

localStorage.setItem('trezorDeviceId', '5E9EC7FD8C24878913C52994'); 
localStorage.setItem('liskCoreUrl', 'https://testnet.lisk.io');
localStorage.setItem('publicKey', '39cf6e906a46ed0d3796ae2f5ee60df77169b5bcb102a63f35f9adad7cb42cef');

Review checklist

slaweet added some commits May 23, 2019

@slaweet slaweet self-assigned this May 23, 2019

slaweet added some commits May 23, 2019

🌱 Implement voting error toasts
- not enough LSK
- too many votes

@slaweet slaweet changed the base branch from 1972-implement-voting-summary-page to development May 23, 2019

slaweet added some commits May 23, 2019

@reyraa reyraa added this to Pull Requests in Version 1.18.0 via automation May 27, 2019

slaweet added some commits May 27, 2019

🌱 Change voting via hwWallet to broadcast txs only in the end
previously it was broadcasting each transaction right after it was
signed.

@slaweet slaweet force-pushed the 1973-implement-voting-submitted-page branch from e8712df to 39e4d9b May 28, 2019

@slaweet slaweet requested a review from massao May 28, 2019

@massao
Copy link
Contributor

left a comment

Just one small comment, and found an issue when voting with HW wallet, and having multiple transactions for voting, if you approve one on the device and cancel the following, it throws an exception.

Also not related to this PR, but found another bug while testing:
image
Even the Go to Confirmation being disabled the Link still works, probably the Button is inside the Link, putting it the otherway around would fix this.

Show resolved Hide resolved src/components/votingV2/index.js Outdated

slaweet added some commits May 29, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

@massao
I cannot reproduce the hw wallet issue - let's talk about it.
I pushed changes to resolve the other two comments.

slaweet added some commits May 29, 2019

♻️ Remove unnecessary timeout from transactionSummary
and rather disable the submit button if no votes selected

@slaweet slaweet requested a review from massao May 29, 2019

@massao

massao approved these changes May 29, 2019

Copy link
Contributor

left a comment

Nice, everything working fine now 👍

@slaweet slaweet merged commit ce44823 into development May 29, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.18.0 automation moved this from Pull Requests to Merged Pull Requests May 29, 2019

@massao massao added the ready label May 29, 2019

@slaweet slaweet deleted the 1973-implement-voting-submitted-page branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.