Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toolbox demo #2073

Merged
merged 15 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

commented May 27, 2019

What issue have I solved?

The team is not very well aware of what toolbox components do we have and what are they capable of. There is no easy way to check that.

I prefer not to use storybook, because in the past it proved to be not used. I think the reasons were

  • it was a separate command to run and took time to start it.
  • it wasn't built on Jenkins and thus eventually was broken and not fixed.

How have I implemented/fixed it?

I created a toolbox page, which should list (eventually) all toolbox components with various ways they can be rendered.

Follow-up tickets: #2090 #2091 #2001

How has this been tested?

Go to https://ci.lisk.io/test/lisk-hub/PR-2073/#/toolbox and see the toolbox demo page
Screenshot 2019-05-27 at 09 07 44

Review checklist

slaweet added some commits May 26, 2019

@reyraa

This comment has been minimized.

Copy link
Member

commented May 27, 2019

It's a good start Vit.

I'd recommend taking it to the next level:

  1. Define a list of the components that we use in different screens similarly and can be moved to toolbox to follow DRY.
  2. On a more elaborated job you can recommend changes on each component which makes them more generic. This can be one simply by adding comments describing desired changes.

All steps ready, we can use this PR as a source of knowledge for our future effort to eliminate the redundant code in Lisk Hub.

@reyraa reyraa self-requested a review May 27, 2019

@slaweet slaweet force-pushed the toolbox-demo branch from 1918dfc to e41b29f May 27, 2019

@slaweet slaweet self-assigned this May 27, 2019

slaweet added some commits May 27, 2019

📚 Create placehoder demo components
... to document what needs a demo
@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

@reyraa thanks for your feedback. Based on it I created this commit to indicate what should be done aa3ffc1

Do you see anything else missing? If yes, let me know and I'll fix it. If not, I'll resolve all the TODOs in the commit above and make this PR pending review.

slaweet added some commits May 28, 2019

@slaweet slaweet force-pushed the toolbox-demo branch from fdaf014 to 86cac76 May 29, 2019

slaweet added some commits May 31, 2019

@slaweet slaweet requested review from osvaldovega and massao Jun 4, 2019

@massao

massao approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

Nice approach 🥇

@slaweet slaweet merged commit d4cf68f into development Jun 4, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the toolbox-demo branch Jun 4, 2019

@slaweet slaweet added the ready label Jun 5, 2019

@reyraa reyraa removed request for reyraa and osvaldovega Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.