Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 404 page - Closes #2057 #2074

Merged
merged 4 commits into from May 28, 2019

Conversation

Projects
4 participants
@Efefefef
Copy link
Contributor

commented May 27, 2019

What issue have I solved?

#2057

How have I implemented/fixed it?

New 404 page

How has this been tested?

Check the design
Click the button to go to The dashboard

Review checklist

Efefefef added some commits May 24, 2019

@Efefefef Efefefef requested a review from slaweet May 27, 2019

@osvaldovega
Copy link
Contributor

left a comment

the code is perfect, just a quick question on the message, after that everything is good

@@ -548,6 +547,7 @@
"What is a Lisk ID?": "What is a Lisk ID?",
"What is your passphrase?": "What is your passphrase?",
"What's New...": "What's New...",
"Whoops, that page is gone.": "Whoops, that page is gone.",

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega May 27, 2019

Contributor

Do you know if this will be the text that we gonna use on this component? I mean I know this is how looks the design but, the text is weird. Maybe just confirm this with Ali to double check that this is it or not/

This comment has been minimized.

Copy link
@Efefefef

Efefefef May 27, 2019

Author Contributor

@reyraa Can you confirm this text, please?

This comment has been minimized.

Copy link
@Efefefef

Efefefef May 27, 2019

Author Contributor

@osvaldovega So Ali the text is okay

@slaweet
Copy link
Member

left a comment

Works well. Just one detail to fix below.

Show resolved Hide resolved src/components/notFound/index.js Outdated

@Efefefef Efefefef requested a review from slaweet May 27, 2019

@slaweet
Copy link
Member

left a comment

👍

@osvaldovega
Copy link
Contributor

left a comment

perfect @Efefefef approved 🏆

@Efefefef Efefefef added this to Pull Requests in Version 1.18.0 via automation May 28, 2019

@Efefefef Efefefef merged commit a81ab86 into development May 28, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.18.0 automation moved this from Pull Requests to Merged Pull Requests May 28, 2019

@Efefefef Efefefef deleted the 2057-implement-404-page branch May 28, 2019

@reyraa reyraa added the ready label Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.