Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement community feed dashboard module - closes #2040 #2076

Merged

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

commented May 27, 2019

What issue have I solved?

-- #2040

How have I implemented/fixed it?

This PR includes the new design for the community feed component.
All the behavior and logic is exactly the same as before just css changes.

After discuss with Ali, however the Show More button at the bottom of the component or use a scroll for see all the feeds, Ali decide to keep it exactly the same for now and then later we will see if this need to be change or not.

How has this been tested?

For check this design, you need login into the app.
Go to the dashboard and edit the URL, change from dashboard to dashboardV2
Then the new design will show up.

As you will see this is having part of the final design for dashboard but will be in the last PR well all dashboard components will be align and make final fix in case is need it for the dashboard component.

NOTE: This PR only includes the design of the community feed part, NOT the final design of all the dashboard component.

Review checklist

osvaldovega added some commits May 24, 2019

Merge branch '2040-implement-community-feed-dashboard-module' of gith…
…ub.com:LiskHQ/lisk-hub into 2040-implement-community-feed-dashboard-module

@osvaldovega osvaldovega requested a review from slaweet May 28, 2019

@slaweet
Copy link
Member

left a comment

  • I would expect that clicking a row leads to twitter like "Show More" did in the old design, but to be checked by @reyraa.

  • AFAIK these files are not needed to be added, there is no settings in this module in the new design:

src/components/newsFeedV2/settingsNewsFeed.css
src/components/newsFeedV2/settingsNewsFeed.js
src/components/newsFeedV2/settingsNewsFeed.test.js
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.test.js Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.test.js Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.css Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.css Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.css Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.css Outdated
@slaweet
Copy link
Member

left a comment

Just two more small things that can be removed.

Show resolved Hide resolved src/components/newsFeedV2/newsFeed.js Outdated
Show resolved Hide resolved src/components/newsFeedV2/newsFeed.css
@slaweet
Copy link
Member

left a comment

Thank you, Osvaldo 👍

@osvaldovega osvaldovega merged commit 6038b5a into development May 28, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@osvaldovega osvaldovega deleted the 2040-implement-community-feed-dashboard-module branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.