Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error boundary page - Closes #2058 #2078

Merged
merged 2 commits into from May 29, 2019

Conversation

Projects
3 participants
@Efefefef
Copy link
Contributor

commented May 28, 2019

What issue have I solved?

#2058

How have I implemented/fixed it?

New design

How has this been tested?

Check prototypes
Check tests

Review checklist

@Efefefef Efefefef self-assigned this May 28, 2019

@Efefefef Efefefef added this to Pull Requests in Version 1.18.0 via automation May 28, 2019

@Efefefef Efefefef requested a review from massao May 28, 2019

@massao
Copy link
Contributor

left a comment

Just one small stuff, everything else is working fine.

Show resolved Hide resolved src/components/errorBoundary/index.js Outdated

@Efefefef Efefefef requested a review from massao May 28, 2019

@Efefefef Efefefef force-pushed the 2058-implement-500-page branch from 05eaacb to 3190d9c May 28, 2019

@slaweet slaweet self-requested a review May 29, 2019

@slaweet
Copy link
Member

left a comment

👍

@massao

massao approved these changes May 29, 2019

Copy link
Contributor

left a comment

🥇

@massao massao added the ready label May 29, 2019

@Efefefef Efefefef merged commit c5f54ea into development May 29, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 95.014%
Details

Version 1.18.0 automation moved this from Pull Requests to Merged Pull Requests May 29, 2019

@Efefefef Efefefef deleted the 2058-implement-500-page branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.