Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename followed accounts to bookmarks - closes #2042 #2079

merged 6 commits into from May 31, 2019


None yet
2 participants
Copy link

commented May 28, 2019

What issue have I solved?

-- #2042

How have I implemented/fixed it?

Change all the places where followedAccount is names and replaced with bookmarks.
The change is for avoid confusions in the code and use it same as mobile, with this change now the code will use bookmarks in every place, including actions, reducers, middleware and component.

How has this been tested?

As this is just a renaming tasks, nothing changed related to logic, so all the code works exactly the same as before but will different brands/labels from followedAccounts to bookmarks.

Review checklist

osvaldovega added some commits May 28, 2019

@osvaldovega osvaldovega self-assigned this May 28, 2019

osvaldovega added some commits May 28, 2019

@slaweet slaweet self-requested a review May 29, 2019

Show resolved Hide resolved docs/ Outdated
Show resolved Hide resolved docs/ Outdated
Copy link

left a comment

I just pushed a commit to fix my previous comments. Everything else looks good.
Thank you, Osvaldo 👍

@slaweet slaweet added the ready label May 31, 2019

@osvaldovega osvaldovega merged commit bf1ad09 into development May 31, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Jenkins test deployment Commit was deployed to test
continuous-integration/jenkins/pr-merge This commit looks good

@osvaldovega osvaldovega deleted the 2042-rename-followed-accounts-to-bookmarks branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.