Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement on boarding on dashboard - Closes #2055 #2086

Merged
merged 5 commits into from Jun 4, 2019

Conversation

3 participants
@massao
Copy link
Contributor

commented Jun 3, 2019

What issue have I solved?

#2055

How have I implemented/fixed it?

  • Updated on boarding module to be easier to reuse;
  • Added illustration and content of on boarding on dashboardV2 component;

How has this been tested?

  • Go to /dashboardV2 and check that the on boarding is there first, if the users closes or go through the on boarding, a flag dashboardOnboarding is set on localStorage.

Review checklist

massao added some commits Jun 3, 2019

♻️ Update Onboarding component propTypes
finalCallback prop isn't required anymore, and only try to execute if
was passed a function

@massao massao self-assigned this Jun 3, 2019

@massao massao requested a review from osvaldovega Jun 3, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 3, 2019

@massao massao marked this pull request as ready for review Jun 3, 2019

@osvaldovega
Copy link
Contributor

left a comment

one small detail, everything else if fine I test the code

@@ -76,6 +98,11 @@ class Dashboard extends React.Component {

return (
<React.Fragment>
<Onboarding
slides={this.getOnboardingSlides()}
ctaLabel={t('Got it, thanks!')}

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega Jun 3, 2019

Contributor

Will be possible to rename this variable, if not now maybe you can put a note just to remember the cahngem but we should rename the parameter ctaLabel to something easier to understand, like finalButtonActionLabel or finalActionLabel

@massao massao requested a review from osvaldovega Jun 3, 2019

@osvaldovega
Copy link
Contributor

left a comment

🏋🏻‍♂️approve

@osvaldovega osvaldovega requested a review from Efefefef Jun 3, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label Jun 4, 2019

@massao massao merged commit 43400db into development Jun 4, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.833%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 4, 2019

@massao massao deleted the 2055-implement-on-boarding-on-dashboard branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.