Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delegates settings toggle - Closes #2094 #2100

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

commented Jun 4, 2019

What issue have I solved?

#2094

How have I implemented/fixed it?

Just removed it from UI. Rest is already cleaned up in 1.20.0

How has this been tested?

Go to settings page, check the toggle is not there.

Review checklist

@slaweet slaweet self-assigned this Jun 4, 2019

@slaweet slaweet force-pushed the 2094-remove-delegates-from-settings branch from b6bacd6 to c5075ae Jun 4, 2019

@slaweet slaweet force-pushed the 2094-remove-delegates-from-settings branch from c5075ae to a016369 Jun 4, 2019

@slaweet slaweet requested a review from massao Jun 4, 2019

@massao

massao approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

🥇

@massao massao requested a review from Efefefef Jun 4, 2019

@Efefefef
Copy link
Contributor

left a comment

Good

@Efefefef Efefefef added the ready label Jun 5, 2019

@slaweet slaweet merged commit ac5b17e into 1.19.0 Jun 5, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2100 at 94.845%
Details

@slaweet slaweet deleted the 2094-remove-delegates-from-settings branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.