Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account to update in voting - Closes #2096 #2101

Merged
merged 5 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

commented Jun 4, 2019

What issue have I solved?

#2096

How have I implemented/fixed it?

The problem was that voting was not getting account based on the active token. So I used a util to make sure that happens.

How has this been tested?

Follow steps in #2096

Review checklist

@slaweet slaweet self-assigned this Jun 4, 2019

@slaweet slaweet requested a review from massao Jun 4, 2019

@massao
Copy link
Contributor

left a comment

Nice! 👍

@massao massao requested a review from Efefefef Jun 4, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 Voting via HW wallet doesn't work. No console output though
image

@slaweet slaweet changed the base branch from 1.19.0 to 1.18.0 Jun 6, 2019

slaweet added some commits May 16, 2019

@slaweet slaweet force-pushed the 2096-fix-account-to-update-in-voting branch from 9f2cf07 to 9901d9c Jun 6, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

I can't believe it, but the problem with hardware wallet was caused by an eslint rule automatically fixed with eslint --fix. More details in 68403b8
Should be good now.

@slaweet slaweet requested a review from massao Jun 6, 2019

🐛 Fix voting with hardware wallet uninitialized account
the problem was that public key was not stored in account object

@slaweet slaweet force-pushed the 2096-fix-account-to-update-in-voting branch from c0eab57 to 68403b8 Jun 6, 2019

@massao massao removed their request for review Jun 7, 2019

@massao massao assigned massao and unassigned slaweet Jun 7, 2019

@slaweet slaweet requested review from Efefefef and removed request for Efefefef Jun 7, 2019

@Efefefef Efefefef self-requested a review Jun 7, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Looks like we have to wait before restarting the build
image

@slaweet slaweet merged commit 657631c into 1.18.0 Jun 7, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the 2096-fix-account-to-update-in-voting branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.