Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-logout reset timer - Closes #2095 #2107

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 5, 2019

What issue have I solved?

#2095

How have I implemented/fixed it?

The issue was that the updateAccount, was always trying to put new data inside a tokenKey, I updated the reducer so if no token is present in the payload, it assumes as a common information to the account.

How has this been tested?

Reproduce steps as described on #2095

Review checklist

@massao massao requested a review from slaweet Jun 5, 2019

@massao massao self-assigned this Jun 5, 2019

@massao massao added this to Pull Requests in Version 1.18.0 via automation Jun 5, 2019

@slaweet

slaweet approved these changes Jun 5, 2019

Copy link
Member

left a comment

Good job, @massao

@slaweet slaweet requested a review from Efefefef Jun 5, 2019

@Efefefef Efefefef added the ready label Jun 5, 2019

@massao massao merged commit 39ba8d3 into 1.19.0 Jun 5, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2107 at 94.831%
Details

Version 1.18.0 automation moved this from Pull Requests to Merged Pull Requests Jun 5, 2019

@massao massao deleted the 2095-fix-reset-timer branch Jun 5, 2019

@massao massao removed this from the Sprint 1 milestone Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.