Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New designs for modals for timeout and sign out - closes #2066 #2110

Merged
merged 3 commits into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

commented Jun 5, 2019

What issue have I solved?

-- #2066

How have I implemented/fixed it?

New design for the modal when is running out of time when the auto-logout option is enabled.
Update css file to match new design

How has this been tested?

Review checklist

@osvaldovega osvaldovega requested a review from massao Jun 5, 2019

@osvaldovega osvaldovega self-assigned this Jun 5, 2019

@massao
Copy link
Contributor

left a comment

And also cherry pick this one: 743fb7e
so the reset timer works properly.

border-radius: 6px;

& .title {
@mixin headingNormalIntermediate;

This comment has been minimized.

Copy link
@massao

massao Jun 5, 2019

Contributor

I just checked with Domenico, and we shouldn't need this mixin, since it's not on the styleguide, we should or use the large or the normal, just check with him in each case.

.dialog {
border-radius: 6px;

This comment has been minimized.

Copy link
@massao

massao Jun 5, 2019

Contributor

Also check with Domenico, if we could use the same border as in the other parts of the application.

massao and others added some commits May 29, 2019

@massao

massao approved these changes Jun 6, 2019

@osvaldovega osvaldovega merged commit 70e2e70 into development Jun 6, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@osvaldovega osvaldovega deleted the 2066-create-the-modals-for-timeout branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.