Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge voting bug fixes to development #2121

Merged
merged 25 commits into from Jun 12, 2019

Conversation

4 participants
@slaweet
Copy link
Member

commented Jun 7, 2019

What issue have I solved?

Closes #2108
Closes #2103
Closes #2097
Closes #2096
Closes #2094
Closes #2093

How have I implemented/fixed it?

I took my bugfixes that were merged into 1.18.0 and fixed merge conflicts with development, because I did rename most of the components in the meantime.

How has this been tested?

Follow steps in all of the issues linked above.

Review checklist

yasharAyari and others added some commits Jun 3, 2019

🐛 Fix voting with hardware wallet uninitialized account
the problem was that public key was not stored in account object
Merge pull request #2118 from LiskHQ/2108-hide-delegates-onboarding-i…
…n-guest-mode

Hide delegates onboarding in guest mode - Closes #2108

@slaweet slaweet self-assigned this Jun 7, 2019

slaweet and others added some commits Jun 7, 2019

🌱 Change primary button on voting error page
... to go back to voting, not voting summary
Merge pull request #2102 from LiskHQ/2097-fix-edit-voting-with-hw
Hide "Edit voting" button for hardware wallets - Closes #2097
Merge pull request #2101 from LiskHQ/2096-fix-account-to-update-in-vo…
…ting

Fix account to update in voting - Closes #2096

@slaweet slaweet marked this pull request as ready for review Jun 7, 2019

@slaweet slaweet requested a review from massao Jun 11, 2019

@slaweet slaweet added this to Pull Requests in Version 1.19.0 via automation Jun 11, 2019

@massao

massao approved these changes Jun 11, 2019

Copy link
Contributor

left a comment

👍

@massao massao requested a review from Efefefef Jun 11, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@slaweet slaweet merged commit ab55186 into development Jun 12, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.05%) to 94.703%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 12, 2019

@slaweet slaweet deleted the merge-voting-bug-fixes branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.