Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wallet page header for BTC and LSK - Closes #1892 #2123

Merged
merged 21 commits into from Jun 12, 2019

Conversation

2 participants
@slaweet
Copy link
Member

commented Jun 7, 2019

What issue have I solved?

#1892

How have I implemented/fixed it?

According to this design https://projects.invisionapp.com/d/main#/console/17570736/365223025/inspect

  • Implemented the "Wallet Details" module. Note that I had to make it wider than in the designs for the longer BTC address to fit in.
  • Adjusted the headline to "Lisk Wallet" instead of avatar and address
  • Hide the "Request BTC" button as there is a separate ticket for it #1890 but now with the "Copy" icon at address, it might not be necessary.

How has this been tested?

Same as #2003

Review checklist

slaweet added some commits Jun 7, 2019

@slaweet slaweet self-assigned this Jun 7, 2019

@slaweet slaweet added this to Pull Requests in Version 1.19.0 via automation Jun 11, 2019

slaweet added some commits Jun 11, 2019

@slaweet slaweet changed the base branch from 1888-minimal-btc-wallet-page to development Jun 11, 2019

@slaweet slaweet requested a review from massao Jun 11, 2019

@slaweet slaweet marked this pull request as ready for review Jun 11, 2019

@massao
Copy link
Contributor

left a comment

Just few comments

slaweet added some commits Jun 12, 2019

@slaweet slaweet requested a review from massao Jun 12, 2019

@massao

massao approved these changes Jun 12, 2019

Copy link
Contributor

left a comment

Thanks Vit 👍

@massao massao requested a review from Efefefef Jun 12, 2019

@slaweet slaweet merged commit 12a0b02 into development Jun 12, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 12, 2019

@slaweet slaweet deleted the 1892-implement-wallet-page-header-for-btc-lsk branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.