Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Request BTC dropdown - Closes #1890 #2134

Merged
merged 23 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented Jun 13, 2019

What issue have I solved?

#1890

How have I implemented/fixed it?

  • Refactored Request component to separate LSK-specific parts
  • Implemented component for the Request BTC-specific parts
  • Implemented a new DropdownButton component to hide a common behaviour of all dropdown buttons in TransactionsOverviewHeader
  • Migrated unit tests of Request component from chai/sinon to jest

How has this been tested?

  • Switch token to BTC
  • Click the "Request BTC" button

Review checklist

@slaweet slaweet self-assigned this Jun 13, 2019

@slaweet slaweet force-pushed the 1890-implement-request-btc-dropdown branch from af236ee to c5c7395 Jun 13, 2019

slaweet added some commits Jun 13, 2019

@slaweet slaweet force-pushed the 1890-implement-request-btc-dropdown branch from c5c7395 to 834156b Jun 13, 2019

slaweet added some commits Jun 13, 2019

@slaweet slaweet marked this pull request as ready for review Jun 13, 2019

@slaweet slaweet force-pushed the 1890-implement-request-btc-dropdown branch from 3cfc7c7 to 1dd0282 Jun 13, 2019

@slaweet slaweet requested a review from massao Jun 14, 2019

slaweet added some commits Jun 13, 2019

@slaweet slaweet force-pushed the 1890-implement-request-btc-dropdown branch from 1dd0282 to dbe5db6 Jun 14, 2019

@massao

massao approved these changes Jun 14, 2019

Copy link
Contributor

left a comment

👍

@massao massao requested review from Efefefef and removed request for Efefefef Jun 14, 2019

@massao massao added the ready label Jun 14, 2019

@slaweet slaweet merged commit 065399e into development Jun 14, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.763%
Details

@slaweet slaweet deleted the 1890-implement-request-btc-dropdown branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.