Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Detail for BTC showing same address for sender and recipient - Closes #2051 #2137

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

commented Jun 13, 2019

What issue have I solved?

-- #2051

How have I implemented/fixed it?

Update the API BTC transaction normalize function to properly get the information and arrange it as should be without pass address parameter to the function

How has this been tested?

Switch to BTC active token
go to wallet
check send/receive tx details
then it doesn't be showing the same address to the tx details.

Review checklist

@osvaldovega osvaldovega self-assigned this Jun 13, 2019

@osvaldovega osvaldovega requested a review from massao Jun 13, 2019

@massao

massao approved these changes Jun 13, 2019

Copy link
Contributor

left a comment

👌

@massao massao requested a review from Efefefef Jun 13, 2019

@Efefefef Efefefef added the ready label Jun 14, 2019

@osvaldovega osvaldovega merged commit 063eb3c into development Jun 14, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage decreased (-0.003%) to 94.669%
Details

@osvaldovega osvaldovega deleted the 2051-transaction-detail-for-BTC-showing-same-address-for-sender-and-recipient branch Jun 14, 2019

@Efefefef Efefefef changed the title Transaction Detail for BTC showing same address for sender and recipient Transaction Detail for BTC showing same address for sender and recipient - Closes #2051 Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.