Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redux files for bookmarks - Closes #2022 #2140

Merged
merged 7 commits into from Jun 19, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 14, 2019

What issue have I solved?

#2022

How have I implemented/fixed it?

  • Replaced subscriber with middleware;
  • Updated getBookmarksFromLocalStorage to save back to localStorage in case it loaded from followedAccounts key;
  • Refactored to use bookmarks instead of accounts where possible;
  • Updated reducers to be less imperative.

How has this been tested?

Bookmarks should still work as before.

Review checklist

@massao massao added this to the Sprint 2 milestone Jun 14, 2019

@massao massao self-assigned this Jun 14, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 14, 2019

@massao massao removed this from the Sprint 2 milestone Jun 14, 2019

massao added some commits Jun 17, 2019

@massao massao added this to the Sprint 3 milestone Jun 18, 2019

massao added some commits Jun 18, 2019

@massao massao requested a review from osvaldovega Jun 18, 2019

@massao massao marked this pull request as ready for review Jun 18, 2019

@massao massao requested a review from yasharAyari Jun 18, 2019

@osvaldovega
Copy link
Contributor

left a comment

good, is easy to read and understand and better implementation🧹

@yasharAyari
Copy link
Member

left a comment

Good job @massao. 👍

@massao massao merged commit 94644b7 into development Jun 19, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.