Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the guest mode of Delegates - Closes #2109 #2141

Merged
merged 5 commits into from Jun 18, 2019

Conversation

Projects
3 participants
@slaweet
Copy link
Member

commented Jun 17, 2019

What issue have I solved?

#2109

How have I implemented/fixed it?

  • I changed the page header content for guest.
  • I fixed the condition for not showing the vote column
  • Changed the table header not to show tabs for guest
  • Refactored the column widths to be defined in one place instead of in both delegates table header and delegate row components.
  • Added missing "Forged" column

How has this been tested?

  • Click "Explore as a guest" on splash screen
  • Click "Delegates" in main menu

Review checklist

@slaweet slaweet self-assigned this Jun 17, 2019

slaweet added some commits Jun 17, 2019

🌱 Add "Forged LSK" column to delegates table
♻️ move column definition to one place

@slaweet slaweet marked this pull request as ready for review Jun 17, 2019

@slaweet slaweet requested a review from massao Jun 17, 2019

@massao
Copy link
Contributor

left a comment

👍

@massao massao requested a review from Efefefef Jun 18, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 I think delegates should start with low letter
image

@slaweet slaweet requested a review from Efefefef Jun 18, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@slaweet slaweet removed the duplicate label Jun 18, 2019

@slaweet slaweet added this to Pull Requests in Version 1.19.0 via automation Jun 18, 2019

@slaweet slaweet merged commit 1ae628b into development Jun 18, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.705%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 18, 2019

@slaweet slaweet deleted the 2109-delegate-page-for-guest branch Jun 18, 2019

@slaweet slaweet changed the title Implement the guest mode of Delegates Implement the guest mode of Delegates - Closes #2109 Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.