Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with initializing hub on linux - Closes #2146 #2147

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
2 participants
@massao
Copy link
Contributor

commented Jun 18, 2019

What issue have I solved?

#2146

How have I implemented/fixed it?

Updated electron version to 4.2.4 and updated deprecated code.

How has this been tested?

Run the build script for linux and check that the .AppImage works.

Review checklist

@massao massao added this to the Sprint 3 milestone Jun 18, 2019

@massao massao self-assigned this Jun 18, 2019

@massao massao added this to Pull Requests in Version 1.18.1 via automation Jun 18, 2019

@massao massao requested review from slaweet and yasharAyari Jun 18, 2019

@slaweet
Copy link
Member

left a comment

Good job, Massao 💟

@slaweet slaweet requested a review from Efefefef Jun 18, 2019

@yasharAyari yasharAyari changed the base branch from 1.18.0 to 1.18.1 Jun 18, 2019

@massao massao merged commit a39a3f7 into 1.18.1 Jun 19, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.785%
Details

Version 1.18.1 automation moved this from Pull Requests to Merged Pull Requests Jun 19, 2019

@massao massao removed request for Efefefef and yasharAyari Jun 19, 2019

@massao massao deleted the 2146-fix-issue-initializing-app-on-linux branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.