Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new design of update modal - Closes #2143 #2149

Merged
merged 2 commits into from Jun 19, 2019

Conversation

Projects
3 participants
@slaweet
Copy link
Member

commented Jun 18, 2019

What issue have I solved?

#2143

How have I implemented/fixed it?

Implemented the design from https://projects.invisionapp.com/d/main#/console/17570736/369141341/preview but not inside the react app, as requested in #2143

How has this been tested?

  • Decrease version number to 1.1.0 in
    "version": "1.18.0-rc.1",
  • Run npm run pack
  • Open Hub with open dist/lisk-hub-mac-1.1.0.dmg
  • See the new update window

Screenshot 2019-06-18 at 12 41 26

Review checklist

@slaweet slaweet self-assigned this Jun 18, 2019

@slaweet slaweet force-pushed the 2143-update-new-release-popup-design branch from 2c8dae2 to be2039a Jun 18, 2019

@slaweet slaweet requested a review from massao Jun 18, 2019

@slaweet slaweet added this to Pull Requests in Version 1.19.0 via automation Jun 18, 2019

@yasharAyari
Copy link
Member

left a comment

Everything looks good. You just need to implement the style of the scrollbar to be aligned with the design. You can find more information about styling a scrollbar in CSS in the below link
https://css-tricks.com/almanac/properties/s/scrollbar/

@slaweet slaweet force-pushed the 2143-update-new-release-popup-design branch from be2039a to 1d5db08 Jun 19, 2019

@massao
Copy link
Contributor

left a comment

Nice, everything is working, just some lines where indented with tabs instead of spaces.

@slaweet

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

just some lines where indented with tabs instead of spaces.

Thank you for the feedback @massao. It's the copy button in invision 😞 I'll fix it.

slaweet added some commits Jun 18, 2019

@slaweet slaweet force-pushed the 2143-update-new-release-popup-design branch from 1d5db08 to 3d3385e Jun 19, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Tabs fixed. Scrollbar fixed. Please review again @yasharAyari @massao

@slaweet slaweet requested review from yasharAyari and massao Jun 19, 2019

@massao

massao approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

👍

@yasharAyari
Copy link
Member

left a comment

👍

@slaweet slaweet merged commit 57b93c8 into development Jun 19, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 19, 2019

@slaweet slaweet deleted the 2143-update-new-release-popup-design branch Jun 19, 2019

@slaweet slaweet added the ready label Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.