Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement animation delegate registration - Closes #2124 #2152

Merged
merged 8 commits into from Jun 20, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 19, 2019

What issue have I solved?

#2124

How have I implemented/fixed it?

  • Added lottie-web to the project;
  • Created Animation component to handle loading animations through lottie;
  • Added delegate Animation to register as delegate page;
  • Styling of animation to correct size will be done on: #2082;
  • Unit test for register as a delegate components will be done on: #2082.

How has this been tested?

  • Go to /toolbox and the animations should be listed there;

Review checklist

@massao massao self-assigned this Jun 19, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 19, 2019

@massao massao added this to the Sprint 3 milestone Jun 19, 2019

@massao massao force-pushed the 2124-implement-animation-delegate-registration branch from 63245f4 to 977a1e2 Jun 19, 2019

@massao massao changed the base branch from development to 2082-implement-new-design-of-register-a-delegate-page Jun 19, 2019

@massao massao force-pushed the 2124-implement-animation-delegate-registration branch from fc172e4 to 159767d Jun 19, 2019

@massao massao changed the base branch from 2082-implement-new-design-of-register-a-delegate-page to development Jun 19, 2019

@massao massao changed the base branch from development to 2082-implement-new-design-of-register-a-delegate-page Jun 19, 2019

@massao massao force-pushed the 2124-implement-animation-delegate-registration branch 2 times, most recently from 2cfcce0 to 3d13aaf Jun 20, 2019

@massao massao marked this pull request as ready for review Jun 20, 2019

@massao massao requested review from osvaldovega and slaweet Jun 20, 2019

@slaweet
Copy link
Member

left a comment

The animation looks/works well.
I'm just not sure about merging it into the branch of @osvaldovega as it will add to the size of his PR, but if @osvaldovega is ok with it, it's fine with me.

@massao massao changed the base branch from 2082-implement-new-design-of-register-a-delegate-page to development Jun 20, 2019

@massao massao force-pushed the 2124-implement-animation-delegate-registration branch from c34d2b6 to c79f82b Jun 20, 2019

massao added some commits Jun 18, 2019

@massao massao force-pushed the 2124-implement-animation-delegate-registration branch from c79f82b to 1374c7c Jun 20, 2019

@slaweet
Copy link
Member

left a comment

👍

@osvaldovega
Copy link
Contributor

left a comment

great 🏋🏻‍♂️

@massao massao merged commit 5f107a8 into development Jun 20, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.774%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 20, 2019

@massao massao deleted the 2124-implement-animation-delegate-registration branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.