Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard not working on wallet page - Closes #2154 #2155

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 20, 2019

What issue have I solved?

#2154

How have I implemented/fixed it?

Cherry picked commit 414a56e fixing defaultContainer for copyToClipboard component on toolbox.

How has this been tested?

Go to /wallet and try clicking on the address to copy and the copy link in request dropdown.

Review checklist

@massao massao added this to the Sprint 3 milestone Jun 20, 2019

@massao massao requested a review from slaweet Jun 20, 2019

@massao massao self-assigned this Jun 20, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 20, 2019

@slaweet
Copy link
Member

left a comment

👍

@massao massao requested a review from Efefefef Jun 20, 2019

@Efefefef Efefefef added duplicate ready and removed duplicate labels Jun 20, 2019

@massao massao merged commit a2b9806 into development Jun 20, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2155 at 94.751%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 20, 2019

@massao massao deleted the 2154-Fix-copy-to-clipboard-toolbox-component branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.