Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wallets from redux - Closes #2033 #2158

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 20, 2019

What issue have I solved?

#2033

How have I implemented/fixed it?

  • Since this is not used anymore, just removed instead of refactoring;
  • Removed all redux files related to wallets;
  • Removed calls to wallets actions.

How has this been tested?

/wallet and /explorer/accounts should still work, since it don't use the wallets data anymore.
There should be no visible changes for the end-user.

Review checklist

@massao massao added this to the Sprint 3 milestone Jun 20, 2019

@massao massao self-assigned this Jun 20, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 20, 2019

@massao massao requested review from slaweet and yasharAyari and removed request for slaweet Jun 20, 2019

@massao massao marked this pull request as ready for review Jun 20, 2019

@massao massao requested a review from slaweet Jun 20, 2019

@slaweet
Copy link
Member

left a comment

Clean cut 🔪 . Thank you @massao

@yasharAyari
Copy link
Member

left a comment

thank you @massao.

@yasharAyari yasharAyari merged commit f9b8ecf into development Jun 21, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 21, 2019

@yasharAyari yasharAyari deleted the 2033-refactor-redux-files-for-wallets branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.