Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust font smoothing on electron - Closes #2166 #2177

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
2 participants
@massao
Copy link
Contributor

commented Jun 21, 2019

What issue have I solved?

#2166

How have I implemented/fixed it?

  • Added font-smoothing to CSS to it's rendered more similar to Sketch designs.

How has this been tested?

Open the app and check that the fonts are less bold, you can check the difference using web inspector:

  • open web inspector, select <body>;
  • toggle -webkit-font-smoothing property on styles tab.

Review checklist

@massao massao added this to the Sprint 3 milestone Jun 21, 2019

@massao massao requested a review from slaweet Jun 21, 2019

@massao massao self-assigned this Jun 21, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 21, 2019

@slaweet
Copy link
Member

left a comment

Thank you, Massao.

@slaweet slaweet added the ready label Jun 21, 2019

@massao massao merged commit 054fdd5 into development Jun 21, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2177 at 94.774%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.