Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust paperwallet design - Closes #2161 #2179

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 21, 2019

What issue have I solved?

#2161

How have I implemented/fixed it?

  • Updated font sizes and spacing in paper wallet;

OBS: Passphrase doesn't look exactly like the design:

  • The font on the design is not used anywhere else on the application, so it was decided to keep the Gilroy;
  • It's not possible with the library we are using to justify the text in a way to use all the available space;

How has this been tested?

  • Go to /register select any avatar and continue;
  • Click on the Download button for the paperwallet;
  • Design should be similar to the design;

Review checklist

@massao massao added this to the Sprint 3 milestone Jun 21, 2019

@massao massao requested a review from slaweet Jun 21, 2019

@massao massao self-assigned this Jun 21, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 21, 2019

@massao massao force-pushed the 2161-Adjust-paperwallet-design branch from f75546e to 0d0e40b Jun 21, 2019

@massao massao force-pushed the 2161-Adjust-paperwallet-design branch from 0d0e40b to 866b792 Jun 21, 2019

@slaweet
Copy link
Member

left a comment

👍

@slaweet slaweet requested a review from Efefefef Jun 24, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 "Paper" and "Encrypted wallet" should be in bold

@massao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

🐛 "Paper" and "Encrypted wallet" should be in bold

@Efefefef It's not possible with the implementation we have right now, we would need to update how the paper wallet is being rendered, to use an HTML as base, and we would have some others limitations with that.

@massao massao requested a review from Efefefef Jun 24, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label Jun 24, 2019

@Efefefef Efefefef merged commit 3bd501e into development Jun 25, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 25, 2019

@Efefefef Efefefef deleted the 2161-Adjust-paperwallet-design branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.