Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align vertical alignment - Closes #2169 #2182

Merged
merged 5 commits into from Jun 24, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 24, 2019

What issue have I solved?

#2169

How have I implemented/fixed it?

  • Updated explorer routes to use same structure as default routes;
  • Removed explorer from routes.js and updated components that were using explorer.path;
  • Moved :global(.offlineWrapper) to app.css instead of send.css;
  • Fixed alignment of transaction detail page and updated to not found instead of old empty state component, as aligned with designers;

How has this been tested?

  • Go to any transaction detail page and the box should be centered;
  • If the url is updated with an invalid transaction ID, should render the Not Found component;

Review checklist

massao added some commits Jun 24, 2019

@massao massao added this to the Sprint 3 milestone Jun 24, 2019

@massao massao requested a review from osvaldovega Jun 24, 2019

@massao massao self-assigned this Jun 24, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 24, 2019

@osvaldovega

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

the code looks good I tried and is working fine.
Quick question, the transaction details page looks different when you resize the screen to a smaller breakpoint is wider, is the ok?

@massao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

the code looks good I tried and is working fine.
Quick question, the transaction details page looks different when you resize the screen to a smaller breakpoint is wider, is the ok?

@osvaldovega There will be another ticket for adjusting the design itself: #2171

@osvaldovega
Copy link
Contributor

left a comment

alignment and code looks good

@osvaldovega osvaldovega requested a review from Efefefef Jun 24, 2019

@Efefefef Efefefef added the ready label Jun 24, 2019

@massao massao merged commit d0a1c6d into development Jun 24, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2182 at 94.776%
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jun 24, 2019

@massao massao deleted the 2169-align-vertical-alignment branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.