Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary functions from delegate actions and reducers - closes #2185 #2186

Conversation

@osvaldovega
Copy link
Contributor

commented Jun 24, 2019

What issue have I solved?

-- #2185

How have I implemented/fixed it?

Update delegate actions files removing unnecessary function.
Update delegate reducer removing unnecessary switch cases.
update delegate registration logic for validate typed nickname
update transaction creation function in summary component
update transaction broadcast function in status component

How has this been tested?

Run the app
Go to delegate registration
type a valid and not used nickname
Then type an used nickname like genesis_1
check that the code is working properly making the corresponding validations and set the correct error messages

Review checklist

@osvaldovega osvaldovega self-assigned this Jun 24, 2019

@osvaldovega osvaldovega added this to Pull Requests in Version 1.20.0 via automation Jun 24, 2019

@osvaldovega osvaldovega added this to the Sprint 3 milestone Jun 24, 2019

@osvaldovega osvaldovega changed the base branch from development to 2082-implement-new-design-of-register-a-delegate-page Jun 25, 2019

@osvaldovega osvaldovega changed the base branch from 2082-implement-new-design-of-register-a-delegate-page to development Jun 26, 2019

@osvaldovega osvaldovega changed the base branch from development to 2082-implement-new-design-of-register-a-delegate-page Jun 26, 2019

osvaldovega added some commits Jun 26, 2019

@Efefefef Efefefef force-pushed the 2082-implement-new-design-of-register-a-delegate-page branch from 7b99da3 to c0c21d7 Jun 27, 2019

osvaldovega added some commits Jun 27, 2019

@osvaldovega osvaldovega changed the base branch from 2082-implement-new-design-of-register-a-delegate-page to development Jun 27, 2019

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

NOTE: All the functionality is working as should be the only thing to take in count is that there are 2 unit test files that need to improve the coverage, for this there are a follow up ticket #2199

@osvaldovega osvaldovega requested a review from massao Jun 27, 2019

osvaldovega added some commits Jun 27, 2019

Merge branch '2185-remove-unnecessary-functions-from-delegate-actions…
…-and-reducers' of github.com:LiskHQ/lisk-hub into 2185-remove-unnecessary-functions-from-delegate-actions-and-reducers
@massao
Copy link
Contributor

left a comment

👍

@massao massao requested a review from Efefefef Jun 27, 2019

@Efefefef
Copy link
Contributor

left a comment

As far as I understand, the bad response should result in the error message. Right now its infinte spinner
image

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

I fixed @Efefefef I missed on level for proper validation, is ready now

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Now it is same as before. You fail the transaction, then retry. Transaction is submitted but you get the failed message :(

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

Sorry @Efefefef I missed a little detail in the reducer, now should be working

@Efefefef Efefefef self-requested a review Jun 28, 2019

@Efefefef
Copy link
Contributor

left a comment

Ok good now

@Efefefef Efefefef added the ready label Jun 28, 2019

osvaldovega added some commits Jun 28, 2019

@osvaldovega osvaldovega merged commit b25dd00 into development Jun 28, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.03%) to 94.745%
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Jun 28, 2019

@osvaldovega osvaldovega deleted the 2185-remove-unnecessary-functions-from-delegate-actions-and-reducers branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.