Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align design of send - Closes #2170 #2204

Merged
merged 10 commits into from Jul 4, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented Jun 28, 2019

What issue have I solved?

#2170

How have I implemented/fixed it?

  • Added avatar placeholder;
  • Fixed bytecount not working, and keeping validation after blue;
  • Added box wrapper to the summary page;
  • Adjusted box width and spacing;

How has this been tested?

Go to send page and the layout should be the new one, all functionalities should be the same;

Review checklist

massao added some commits Jun 28, 2019

@massao massao added this to the Sprint 3 milestone Jun 28, 2019

@massao massao self-assigned this Jun 28, 2019

@massao massao added this to Pull Requests in Version 1.19.0 via automation Jun 28, 2019

massao added some commits Jun 28, 2019

@massao massao requested a review from osvaldovega Jun 28, 2019

@massao massao marked this pull request as ready for review Jun 28, 2019

@yasharAyari
Copy link
Member

left a comment

👍

@Efefefef Efefefef self-requested a review Jun 28, 2019

@massao massao removed the request for review from osvaldovega Jun 28, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 When you enter more than 64bytes the circle should turn to red exclamation mark
image

🐛
image

🐛 Usd amount has the same size in the designs
image

🐛 Fee amount wrong font
image

massao added some commits Jun 28, 2019

@massao massao requested a review from Efefefef Jun 28, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 Avatar and text in Recipient input are not aligned
image

image

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

The last comment is a mistake. I Approve

@Efefefef Efefefef merged commit 647e4e2 into development Jul 4, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.19.0 automation moved this from Pull Requests to Merged Pull Requests Jul 4, 2019

@Efefefef Efefefef deleted the 2170-align-design-of-send branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.