Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement new release banner - Closes #2144 #2300
What issue have I solved?
How have I implemented/fixed it?
The release summary is fetched from the release note and consists of the content of the first html tag.
The following items will be done in a followup ticket #2317 .
How has this been tested?
Change version on package.json, build the application an run with electront o see that the banner shows up.
Aug 3, 2019
slaweet left a comment •
Otherwise, it works well. I'm still going through the code...
I'm checking into it.
By what I discussed with @reyraa for future releases we are going to have the first line being a heading with the summary. But we can check other alternatives with him, if needed.
This seems to be because the button has a
Will check and update this comment with the conclusion.
The first line with summary sounds good. Will there be some formatting, like bold or H1-6 @reyraa ? IMO it makes sense to have the summary somehow highlighted on Github as one of the most important parts. Can we already do it for the latest release?
@massao I jazzed up this release note so you can test easily.
For now I set the releaseSummary as being the first
Fixed the wrapping issue, but had to disable show/hide animations, as it was relying on a specific height.