Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add bookmark page - Closes #2314 #2323

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@slaweet
Copy link
Member

commented Aug 8, 2019

What issue have I solved?

#2314

How have I implemented/fixed it?

Removed the no-longer-used store value

How has this been tested?

Follow steps in #2314

Review checklist

@slaweet slaweet self-assigned this Aug 8, 2019

@slaweet slaweet added this to Pull Requests in Version 1.20.0 via automation Aug 8, 2019

@slaweet slaweet requested a review from massao Aug 8, 2019

@massao

massao approved these changes Aug 8, 2019

Copy link
Contributor

left a comment

Nice 👍

@massao massao requested a review from Efefefef Aug 8, 2019

@Efefefef Efefefef added the ready label Aug 8, 2019

@slaweet slaweet merged commit acf2a94 into development Aug 8, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2323 at 94.9%
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 8, 2019

@slaweet slaweet deleted the 2314-fix-error-on-adding-bookmark branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.