Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dialog from redux - Closes #2032 #2326

Merged
merged 12 commits into from Aug 9, 2019

Conversation

@massao
Copy link
Contributor

commented Aug 8, 2019

What issue have I solved?

#2032

How have I implemented/fixed it?

  • Replace timeout dialogs with new singleton;
  • Replace hardware wallet disconnected with singleton;
  • Added animation to dialog;
  • Removed redux and others files related to dialog;

How has this been tested?

For testing the timeout dialog, you can open ReactDevTools, select the Provider node, and run this on the console, to set the expireTime to 1 minute.

$r.store.dispatch({
  data: {
    expireTime: Date.now() + 60000 // + 2000 for the session timeout dialog
  },
  type: 'ACCOUNT_UPDATED'
});

Review checklist

@massao massao self-assigned this Aug 8, 2019

@massao massao added this to Pull Requests in Version 1.20.0 via automation Aug 8, 2019

@massao massao force-pushed the 2032-remove-dialog-from-redux branch from 101e6ef to 44b6a07 Aug 8, 2019

massao added some commits Aug 7, 2019

@massao massao force-pushed the 2032-remove-dialog-from-redux branch from 44b6a07 to 0bd1698 Aug 9, 2019

@massao massao marked this pull request as ready for review Aug 9, 2019

@massao massao requested a review from slaweet Aug 9, 2019

@slaweet

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

I guess it was not introduced by this ticket, but the modals should have box-shadow: 0 2px 4px 0 rgba(12,21,46,0.24); according to
https://projects.invisionapp.com/d/main#/console/17570736/364220520/preview

Some have less some more:
Screenshot 2019-08-09 at 10 06 13

@slaweet
Copy link
Member

left a comment

Works and looks great 👍

I have just one small detail/question below

@slaweet

slaweet approved these changes Aug 9, 2019

Copy link
Member

left a comment

Great, Massao. 👍

@massao massao merged commit d2bb3df into development Aug 9, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 9, 2019

@reyraa reyraa deleted the 2032-remove-dialog-from-redux branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.