Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency dropdown in settings is kinda buggy - Closes #2305 #2327

Merged

Conversation

@osvaldovega
Copy link
Contributor

commented Aug 8, 2019

What issue have I solved?

-- #2305

How have I implemented/fixed it?

In this PR just 2 things are change.

-[x] Change the onFocus to onClick for the currency input.
-[x] Add a css class to rotate the arrow when the dropdown is open/close.

How has this been tested?

  1. Run the app.
  2. Go to settings page.
  3. Do a click in the currency input.
  4. See the arrow rotating.

Review checklist

@osvaldovega osvaldovega self-assigned this Aug 8, 2019

@osvaldovega osvaldovega added this to Pull Requests in Version 1.20.0 via automation Aug 8, 2019

osvaldovega and others added some commits Aug 8, 2019

@osvaldovega osvaldovega requested a review from massao Aug 9, 2019

@osvaldovega osvaldovega added this to the Sprint 6 milestone Aug 9, 2019

@massao

massao approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

Nice job guys 🤜🤛

@massao massao requested a review from Efefefef Aug 9, 2019

@Efefefef Efefefef added the ready label Aug 9, 2019

@osvaldovega osvaldovega merged commit 6f75b69 into development Aug 9, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 9, 2019

@osvaldovega osvaldovega deleted the 2305-currency-dropdown-in-settings-is-kinda-buggy branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.