Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip link alignment - Closes #2306 #2329

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@slaweet
Copy link
Member

commented Aug 8, 2019

What issue have I solved?

#2306

How have I implemented/fixed it?

  • There was global css for footer in delegate registration, so I made the selector more specific.
  • Also found one string missing from i18n and fixed it.

How has this been tested?

  • Go to "Create account" and hover the tooltip
  • Check that delegate registration styles keep the same

Review checklist

slaweet added some commits Aug 8, 2019

@slaweet slaweet self-assigned this Aug 8, 2019

@slaweet slaweet added this to Pull Requests in Version 1.20.0 via automation Aug 8, 2019

@slaweet slaweet requested a review from massao Aug 8, 2019

@massao

massao approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

Thanks Vit! 🎉

@massao massao requested a review from Efefefef Aug 9, 2019

@Efefefef Efefefef added the ready label Aug 9, 2019

@slaweet slaweet merged commit 6820784 into development Aug 9, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-2329 at 94.9%
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 9, 2019

@slaweet slaweet deleted the 2306-fix-tooltip-link-alignment branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.