Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fee in balance chart and transaction table #2336

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@slaweet
Copy link
Member

commented Aug 8, 2019

What issue have I solved?

  • Fee on transactions table contained "&nbsp"
  • Balance chart could go to minus

Screenshot 2019-08-08 at 17 22 37

How have I implemented/fixed it?

Straightforwardly :-)

How has this been tested?

See account 15610359283786884938L on Testnet https://ci.lisk.io/test/lisk-hub/PR-2336/#/explorer/accounts/15610359283786884938L

Review checklist

slaweet added some commits Aug 8, 2019

🐛 Fix balanceChart not to go under 0
It was counting fee to incoming transactions, if account had 1 incoming
transaction of 100 LSK, the balance chart would start from -0.1 LSK

@slaweet slaweet self-assigned this Aug 8, 2019

@slaweet slaweet added this to Pull Requests in Version 1.20.0 via automation Aug 8, 2019

@slaweet slaweet requested a review from massao Aug 8, 2019

@massao

massao approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

👍

@massao massao requested a review from Efefefef Aug 9, 2019

@Efefefef Efefefef added the ready label Aug 9, 2019

@slaweet slaweet merged commit ea6b1c8 into development Aug 9, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.9%
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 9, 2019

@slaweet slaweet deleted the fix-bugs_B-) branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.