Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align design delegates page - Closes #2167 #2347 #2337

Merged
merged 10 commits into from Aug 13, 2019

Conversation

@massao
Copy link
Contributor

commented Aug 9, 2019

What issue have I solved?

#2167
#2347

How have I implemented/fixed it?

  • Adjust table columns spacing;
  • Adjust search input size;
  • Adjust LSK signs;
  • Adjust cropped tooltip;
  • Disable register as delegate when using hwWallet.

Didn't change the things that were commented here: #2167 (comment)

How has this been tested?

Delegates page should be as in the designs.

Review checklist

massao added some commits Aug 9, 2019

@massao massao self-assigned this Aug 9, 2019

@massao massao added this to Pull Requests in Version 1.20.0 via automation Aug 9, 2019

@massao massao marked this pull request as ready for review Aug 9, 2019

@massao massao requested review from slaweet and osvaldovega and removed request for slaweet Aug 9, 2019

@massao massao force-pushed the 2167-align-design-delegates-page branch from 2f750f8 to 7d4769f Aug 9, 2019

@osvaldovega
Copy link
Contributor

left a comment

great 👍🏻

@osvaldovega osvaldovega requested a review from Efefefef Aug 9, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 Added/Removed votes should have smaller height
🐛 3 Tooltips are back in design files as I can see. Can we request the text for the Forged LSK and implement it?
🐛 By LSK sign problem I meant that some columns have LSK sign in the header but some have LSK sign in the rows inside the table. Yashar had a decision where it should be placed

massao added some commits Aug 12, 2019

@massao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

🐛 Added/Removed votes should have smaller height

Fixed in 51d322c

🐛 3 Tooltips are back in design files as I can see. Can we request the text for the Forged LSK and implement it?

@reyraa is checking into this and should get back at us.

🐛 By LSK sign problem I meant that some columns have LSK sign in the header but some have LSK sign in the rows inside the table. Yashar had a decision where it should be placed

Talked with Yashar and implemented as suggested in c86e9db

@massao massao changed the title Align design delegates page - Closes #2167 Align design delegates page - Closes #2167 #2347 Aug 13, 2019

@massao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@Efefefef Updated the tooltips as described in #2347

@massao massao requested a review from Efefefef Aug 13, 2019

@Efefefef
Copy link
Contributor

left a comment

Positioning should be fixed

image

@massao massao force-pushed the 2167-align-design-delegates-page branch from 98ae187 to 27ab717 Aug 13, 2019

@massao massao requested a review from Efefefef Aug 13, 2019

@Efefefef Efefefef added the ready label Aug 13, 2019

@massao massao merged commit 1b0595c into development Aug 13, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 13, 2019

@massao massao deleted the 2167-align-design-delegates-page branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.