Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Generalize toolbox box component - Closes #2313 #2338
What issue have I solved?
How have I implemented/fixed it?
Improvements to the Box component
There will be a follow-up to update all components #2342
How has this been tested?
3 times, most recently
Aug 9, 2019
yasharAyari left a comment •
The issue that you working on is too big and general. Please split this into blew tickets and fix each issue in a separated pull request and change the type of the current issue to an epic. So it would be easier for the team in the future to follow the changes that you made.
@yasharAyari I commits so that this PR is only changing the Box and its sub-components. And there is a follow-up in progress that aims to change other components to use the new Box capabilities. #2343
I think this PR is 3 story points and the next one will be 5 story points, so I'll keep an eye on the size of the follow-up and if it starts growing too much, I'll cut it in half.
Having said that, this PR is ready for review.