Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code to use Model from connected device - Closes #2339 #2340

Merged
merged 7 commits into from Aug 13, 2019

Conversation

@massao
Copy link
Contributor

commented Aug 12, 2019

What issue have I solved?

#2339

How have I implemented/fixed it?

Just updated the code to use the connected model instead of hardcoded one.
The API is the same between Nano X and Nano S, so there was no need for any extra changes.
Fixed an issue with the detection of disconnected device, removing the wrong device.

How has this been tested?

Plug Nano S and Nano X, and check that the string update accordingly.

Review checklist

@massao massao self-assigned this Aug 12, 2019

@massao massao added this to Pull Requests in Version 1.20.0 via automation Aug 12, 2019

@massao massao requested a review from osvaldovega Aug 12, 2019

massao added some commits Aug 12, 2019

@osvaldovega
Copy link
Contributor

left a comment

There is a problem with the Nano S, even after you remove/disconnect the device the application still see it and try to get accounts.

Screen Shot 2019-08-12 at 17 04 46

There is something in the connect disconnect about this.
In the other hand with the Nano X you just need to connect the device and the app listed it, even before you enter the pin

massao added some commits Aug 12, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice I tried again and works good.
code is good too🏆

@osvaldovega osvaldovega requested a review from Efefefef Aug 13, 2019

@Efefefef
Copy link
Contributor

left a comment

Perfect

@Efefefef Efefefef added the ready label Aug 13, 2019

@massao massao merged commit 459ecfe into development Aug 13, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Version 1.20.0 automation moved this from Pull Requests to Merged Pull Requests Aug 13, 2019

@massao massao deleted the adjust-ledger-copy-with-correct-model branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.