Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discreet mode field to settings - Closes #2330 #2344

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@massao
Copy link
Contributor

commented Aug 12, 2019

What issue have I solved?

#2330

How have I implemented/fixed it?

  • Update settings store to have a disabled discreet mode as default.
  • Add discreet mode input into settings, copy is different than design due to the correct one being discreet instead of discrete.

How has this been tested?

It's needed to set a discreet into localStorage to see the option in settings. It is not displayed by default because the functionality is not yet implemented (goal of another ticket: #2331).

localStorage.setItem('discreet', true);

Changing the field in settings should update the value of discreetMode inside settings store in redux.

Review checklist

@massao massao self-assigned this Aug 12, 2019

@massao massao requested a review from slaweet Aug 14, 2019

@massao massao marked this pull request as ready for review Aug 14, 2019

@slaweet
Copy link
Member

left a comment

The code is good.

The only problem is the position of the settings item. Should be after "2nd passphrase" not before, now that there is a design for it:
https://projects.invisionapp.com/d/main#/console/18170373/378588775/preview

Another concern is when to merge it: This PR should IMO be merged only after we have "Bump to Hub 1.20.0-beta.1" commit on development branch.

@massao massao requested a review from slaweet Aug 14, 2019

@massao massao force-pushed the 2330-implement-discreet-mode-toggle-settings branch from 71328b1 to f08c016 Aug 14, 2019

@slaweet
Copy link
Member

left a comment

Thank you, Massao.

@massao massao requested a review from Efefefef Aug 14, 2019

@Efefefef Efefefef added the ready label Aug 14, 2019

@massao massao merged commit 25a651b into development Aug 14, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@massao massao deleted the 2330-implement-discreet-mode-toggle-settings branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.