New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error toast after auto-update and auto-restart #1062

Closed
ginacontrino opened this Issue May 8, 2018 · 0 comments

Comments

2 participants
@ginacontrino
Contributor

ginacontrino commented May 8, 2018

Expected behaviour

There should be no error toast after auto-update and auto-restart

Actual behaviour

There is an error toast "URL invalid"

@ginacontrino ginacontrino created this issue from a note in Version 2.0.0 (Issues) May 8, 2018

@ginacontrino ginacontrino self-assigned this May 8, 2018

@ginacontrino ginacontrino added the *easy label May 8, 2018

@slaweet slaweet added the bug label May 8, 2018

@ginacontrino ginacontrino assigned slaweet and unassigned ginacontrino May 8, 2018

slaweet added a commit that referenced this issue May 15, 2018

Don't show error toast when invalid link opened
because it doesn't tell the user what exactly is wrong with the url
and because it causes issues in auto updater #1062

@slaweet slaweet closed this in 49d1cfa May 17, 2018

Version 2.0.0 automation moved this from Issues to Closed Issues May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment