New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some E2E tests were failing on Jenkins - Closes #1055 #1056

Merged
merged 2 commits into from Apr 17, 2018

Conversation

2 participants
@yasharAyari
Member

yasharAyari commented Apr 16, 2018

What was the problem?

Some E2E tests were failing on Jenkins

Review checklist

  • The PR solves #1055
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

@yasharAyari yasharAyari self-assigned this Apr 16, 2018

@yasharAyari yasharAyari added this to Issues in Version 2.0.0 via automation Apr 16, 2018

@yasharAyari yasharAyari requested a review from slaweet Apr 16, 2018

@slaweet

Good catch, Yashar.

@slaweet slaweet added ready and removed 🏗 in progress labels Apr 17, 2018

@yasharAyari yasharAyari merged commit 51fee93 into 2.0.0 Apr 17, 2018

4 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 91.852%
Details
security/snyk - package.json No new issues
Details

@yasharAyari yasharAyari deleted the 1055-some-e2e-tests-are-failing-on-jenkins branch Apr 17, 2018

@yasharAyari yasharAyari changed the title from Add 'serve' script to node scripts and use it in jenkinsfile - Closes #1055 to Some E2E tests were failing on Jenkins - Closes #1055 Apr 17, 2018

@yasharAyari yasharAyari moved this from Issues to Merged Pull Requests in Version 2.0.0 Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment