New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep selected network option when creating new ID - Closes #1031 #1064

Merged
merged 1 commit into from May 9, 2018

Conversation

2 participants
@ginacontrino
Contributor

ginacontrino commented May 8, 2018

What was the problem?

The selected network option reverted to mainnet when trying to create a new ID

How did I fix it?

By saving the selected network option in localStorage

How to test it?

Select a network option & create a new account -> afterwards you should be logged in with the option you selected

Review checklist

  • The PR solves #1031
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices
Gina Contrino

@ginacontrino ginacontrino self-assigned this May 8, 2018

@ginacontrino ginacontrino added this to Issues in Version 2.0.0 via automation May 8, 2018

@ginacontrino ginacontrino requested a review from slaweet May 8, 2018

@ginacontrino ginacontrino moved this from Issues to Pull Requests in Version 2.0.0 May 8, 2018

@slaweet

slaweet approved these changes May 9, 2018

Thank you Gina

@ginacontrino ginacontrino merged commit 0dd5219 into 2.0.0 May 9, 2018

5 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 91.87%
Details
security/snyk - package.json No dependency changes
Details

Version 2.0.0 automation moved this from Pull Requests to Merged Pull Requests May 9, 2018

@ginacontrino ginacontrino deleted the 1031-network-login-after-id-creation branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment