New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error toast after autoupdate - Closes #1062 #1068

Merged
merged 3 commits into from May 17, 2018

Conversation

2 participants
@slaweet
Member

slaweet commented May 15, 2018

What was the problem?

See #1062

How did I fix it?

Removed the error toast

How to test it?

That's close to impossible because you need the change to be released.

Review checklist

  • The PR solves #1062
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

slaweet added some commits May 15, 2018

Allow upper case in launch protocol
Because lower-case l in core 1.0 is no longer allowed
Don't show error toast when invalid link opened
because it doesn't tell the user what exactly is wrong with the url
and because it causes issues in auto updater #1062

@slaweet slaweet self-assigned this May 15, 2018

@slaweet slaweet added this to Issues in Version 2.0.0 via automation May 15, 2018

@slaweet slaweet moved this from Issues to Pull Requests in Version 2.0.0 May 15, 2018

@slaweet slaweet requested a review from reyraa May 16, 2018

Show outdated Hide outdated src/utils/externalLinks.js Outdated
Show outdated Hide outdated src/utils/externalLinks.js Outdated
Allow uppercase 'LISK' in launch protocol
... and display error toast only if lisk:// launch protocol and
invalid URL was detected
@reyraa

reyraa approved these changes May 17, 2018

Thanks Vit

@slaweet slaweet merged commit 49d1cfa into 2.0.0 May 17, 2018

3 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json No dependency changes
Details

Version 2.0.0 automation moved this from Pull Requests to Merged Pull Requests May 17, 2018

@slaweet slaweet deleted the 1062-remove-error-toast-after-autoupdate branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment