New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow lowercase l in address - Closes #1070 #1071

Merged
merged 2 commits into from May 23, 2018

Conversation

2 participants
@slaweet
Member

slaweet commented May 17, 2018

What was the problem?

Two problems:

  • api call failure was not handled
  • lowercase l in address was allowed

How did I fix it?

  • handled api call failure
  • disabled lowercase l in address

How to test it?

Try to send a transaction to 234235235l

Review checklist

  • The PR solves #1070
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

@slaweet slaweet self-assigned this May 17, 2018

@slaweet slaweet added this to Issues in Version 2.0.0 via automation May 17, 2018

@slaweet slaweet requested a review from yasharAyari May 17, 2018

slaweet added some commits May 17, 2018

@slaweet slaweet moved this from Issues to Pull Requests in Version 2.0.0 May 17, 2018

@yasharAyari

👍

@yasharAyari yasharAyari merged commit 12ccd0d into 2.0.0 May 23, 2018

3 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json No dependency changes
Details

Version 2.0.0 automation moved this from Pull Requests to Merged Pull Requests May 23, 2018

@slaweet slaweet deleted the 1070-disallow-lowercase-address branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment