New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete when changing a vote - Closes #990 #1074

Merged
merged 1 commit into from May 23, 2018

Conversation

2 participants
@slaweet
Member

slaweet commented May 18, 2018

What was the problem?

Described in #990

How did I fix it?

I updated the filter of autocomplete delegates.

How to test it?

Follow "Steps to reproduce" in #990

Review checklist

  • The PR solves #990
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

@slaweet slaweet self-assigned this May 18, 2018

@slaweet slaweet added this to Issues in Version 2.0.0 via automation May 18, 2018

@slaweet slaweet requested a review from reyraa May 18, 2018

@slaweet slaweet moved this from Issues to Pull Requests in Version 2.0.0 May 18, 2018

@yasharAyari

good job.

@yasharAyari yasharAyari merged commit 97464ac into 2.0.0 May 23, 2018

4 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1074 at 89.063%
Details
security/snyk - package.json No dependency changes
Details

Version 2.0.0 automation moved this from Pull Requests to Merged Pull Requests May 23, 2018

@slaweet slaweet deleted the 990-fix-vote-autocomplete branch May 23, 2018

@slaweet slaweet referenced this pull request May 23, 2018

Closed

Fix autocomplete when changing a vote - Closes #990 #1000

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment